Re: [PATCH 05/16] qapi/expr.py: move string check upwards in check_type

2020-09-24 Thread Cleber Rosa
On Tue, Sep 22, 2020 at 05:13:02PM -0400, John Snow wrote: > It's a simple case, shimmy the early return upwards. > > Signed-off-by: John Snow I'm only acking this because of the very graphical "shimmy dance" movie that played in my mind. Reviewed-by: Cleber Rosa signature.asc Description:

Re: [PATCH 05/16] qapi/expr.py: move string check upwards in check_type

2020-09-23 Thread Eduardo Habkost
On Tue, Sep 22, 2020 at 05:13:02PM -0400, John Snow wrote: > It's a simple case, shimmy the early return upwards. > > Signed-off-by: John Snow Reviewed-by: Eduardo Habkost -- Eduardo

[PATCH 05/16] qapi/expr.py: move string check upwards in check_type

2020-09-22 Thread John Snow
It's a simple case, shimmy the early return upwards. Signed-off-by: John Snow --- scripts/qapi/expr.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py index 67892502e9..3f5af5f5e4 100644 --- a/scripts/qapi/expr.py +++