Re: [PATCH 05/17] block: Don't advertise zero_init_truncate with encryption

2020-02-10 Thread Alberto Garcia
On Fri 31 Jan 2020 06:44:24 PM CET, Eric Blake wrote: > Commit 38841dcd correctly argued that having qcow2 blindly return 1 > for .bdrv_has_zero_init() is wrong for preallocated images built on > block devices, while .bdrv_has_zero_init_truncate() can still return 1 > because it is only relied on w

[PATCH 05/17] block: Don't advertise zero_init_truncate with encryption

2020-01-31 Thread Eric Blake
Commit 38841dcd correctly argued that having qcow2 blindly return 1 for .bdrv_has_zero_init() is wrong for preallocated images built on block devices, while .bdrv_has_zero_init_truncate() can still return 1 because it is only relied on when changing size with PREALLOC_MODE_OFF (and this is true eve