Re: [PATCH 05/18] target/arm: Move CPU QOM type definitions to "hw/arm/cpu.h"

2023-01-11 Thread Philippe Mathieu-Daudé
On 11/1/23 21:02, Richard Henderson wrote: On 1/10/23 08:43, Philippe Mathieu-Daudé wrote: +++ b/target/arm/cpu.h @@ -26,6 +26,7 @@   #include "cpu-qom.h"   #include "exec/cpu-defs.h"   #include "qapi/qapi-types-common.h" +#include "hw/arm/cpu.h" I'm not a fan of this. If you want a smaller v

Re: [PATCH 05/18] target/arm: Move CPU QOM type definitions to "hw/arm/cpu.h"

2023-01-11 Thread Richard Henderson
On 1/10/23 08:43, Philippe Mathieu-Daudé wrote: +++ b/target/arm/cpu.h @@ -26,6 +26,7 @@ #include "cpu-qom.h" #include "exec/cpu-defs.h" #include "qapi/qapi-types-common.h" +#include "hw/arm/cpu.h" I'm not a fan of this. If you want a smaller version of cpu-qom.h here in target/arm/, for

[PATCH 05/18] target/arm: Move CPU QOM type definitions to "hw/arm/cpu.h"

2023-01-10 Thread Philippe Mathieu-Daudé
Units including "target/arm/cpu.h" can't be built once via meson's softmmu_ss[] source set. Since this header depends on specific definitions such the word size (32 or 64-bit), for ARM such units must go to the per-target arm_ss[]. We want to expose few architectural definitions to hardware models