Re: [PATCH 05/22] plugins: Move function pointer in qemu_plugin_dyn_cb

2024-03-19 Thread Pierrick Bouvier
On 3/20/24 01:30, Richard Henderson wrote: On 3/19/24 03:18, Pierrick Bouvier wrote: On 3/16/24 05:57, Richard Henderson wrote: The out-of-line function pointer is mutually exclusive with inline expansion, so move it into the union. Wrap the pointer in a structure named 'regular' to match

Re: [PATCH 05/22] plugins: Move function pointer in qemu_plugin_dyn_cb

2024-03-19 Thread Richard Henderson
On 3/19/24 03:18, Pierrick Bouvier wrote: On 3/16/24 05:57, Richard Henderson wrote: The out-of-line function pointer is mutually exclusive with inline expansion, so move it into the union. Wrap the pointer in a structure named 'regular' to match PLUGIN_CB_REGULAR. Signed-off-by: Richard

Re: [PATCH 05/22] plugins: Move function pointer in qemu_plugin_dyn_cb

2024-03-19 Thread Pierrick Bouvier
On 3/16/24 05:57, Richard Henderson wrote: The out-of-line function pointer is mutually exclusive with inline expansion, so move it into the union. Wrap the pointer in a structure named 'regular' to match PLUGIN_CB_REGULAR. Signed-off-by: Richard Henderson --- include/qemu/plugin.h | 4 +++-

Re: [PATCH 05/22] plugins: Move function pointer in qemu_plugin_dyn_cb

2024-03-18 Thread Alex Bennée
Richard Henderson writes: > The out-of-line function pointer is mutually exclusive > with inline expansion, so move it into the union. > Wrap the pointer in a structure named 'regular' to match > PLUGIN_CB_REGULAR. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

[PATCH 05/22] plugins: Move function pointer in qemu_plugin_dyn_cb

2024-03-15 Thread Richard Henderson
The out-of-line function pointer is mutually exclusive with inline expansion, so move it into the union. Wrap the pointer in a structure named 'regular' to match PLUGIN_CB_REGULAR. Signed-off-by: Richard Henderson --- include/qemu/plugin.h | 4 +++- accel/tcg/plugin-gen.c | 4 ++--