Re: [PATCH 06/14] block/mirror: drop extra error propagation in commit_active_start()

2020-09-17 Thread Alberto Garcia
On Wed 09 Sep 2020 08:59:22 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > Let's check return value of mirror_start_job to check for failure > instead of local_err. > > Rename ret to job, as ret is usually integer variable. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garc

Re: [PATCH 06/14] block/mirror: drop extra error propagation in commit_active_start()

2020-09-10 Thread Greg Kurz
On Wed, 9 Sep 2020 21:59:22 +0300 Vladimir Sementsov-Ogievskiy wrote: > Let's check return value of mirror_start_job to check for failure > instead of local_err. > > Rename ret to job, as ret is usually integer variable. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- Reviewed-by: Greg

[PATCH 06/14] block/mirror: drop extra error propagation in commit_active_start()

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
Let's check return value of mirror_start_job to check for failure instead of local_err. Rename ret to job, as ret is usually integer variable. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/mirror.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/block/mi