Re: [PATCH 06/15] hw/riscv/spike.c: load initrd right after riscv_load_kernel()

2022-12-26 Thread Daniel Henrique Barboza
On 12/26/22 10:49, Bin Meng wrote: On Fri, Dec 23, 2022 at 6:04 PM Bin Meng wrote: On Thu, Dec 22, 2022 at 2:28 AM Daniel Henrique Barboza wrote: This will make the code more in line with what the other boards are doing. We'll also avoid an extra check to machine->kernel_filename since we

Re: [PATCH 06/15] hw/riscv/spike.c: load initrd right after riscv_load_kernel()

2022-12-26 Thread Bin Meng
On Fri, Dec 23, 2022 at 6:04 PM Bin Meng wrote: > > On Thu, Dec 22, 2022 at 2:28 AM Daniel Henrique Barboza > wrote: > > > > This will make the code more in line with what the other boards are > > doing. We'll also avoid an extra check to machine->kernel_filename since > > we already checked

Re: [PATCH 06/15] hw/riscv/spike.c: load initrd right after riscv_load_kernel()

2022-12-23 Thread Bin Meng
On Thu, Dec 22, 2022 at 2:28 AM Daniel Henrique Barboza wrote: > > This will make the code more in line with what the other boards are > doing. We'll also avoid an extra check to machine->kernel_filename since > we already checked that before executing riscv_load_kernel(). > > Signed-off-by:

Re: [PATCH 06/15] hw/riscv/spike.c: load initrd right after riscv_load_kernel()

2022-12-22 Thread Alistair Francis
On Thu, Dec 22, 2022 at 4:28 AM Daniel Henrique Barboza wrote: > > This will make the code more in line with what the other boards are > doing. We'll also avoid an extra check to machine->kernel_filename since > we already checked that before executing riscv_load_kernel(). > > Signed-off-by:

Re: [PATCH 06/15] hw/riscv/spike.c: load initrd right after riscv_load_kernel()

2022-12-22 Thread Philippe Mathieu-Daudé
On 21/12/22 19:22, Daniel Henrique Barboza wrote: This will make the code more in line with what the other boards are doing. We'll also avoid an extra check to machine->kernel_filename since we already checked that before executing riscv_load_kernel(). Signed-off-by: Daniel Henrique Barboza

[PATCH 06/15] hw/riscv/spike.c: load initrd right after riscv_load_kernel()

2022-12-21 Thread Daniel Henrique Barboza
This will make the code more in line with what the other boards are doing. We'll also avoid an extra check to machine->kernel_filename since we already checked that before executing riscv_load_kernel(). Signed-off-by: Daniel Henrique Barboza --- hw/riscv/spike.c | 31