Re: [PATCH 06/20] hw/riscv: Use generic DeviceState instead of PFlashCFI01

2023-01-07 Thread Bin Meng
On Thu, Jan 5, 2023 at 6:47 AM Philippe Mathieu-Daudé wrote: > > Nothing here requires access to PFlashCFI01 internal fields: > use the inherited generic DeviceState. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/riscv/virt.c | 9 + > include/hw/riscv/virt.h | 3 +-- > 2 f

Re: [PATCH 06/20] hw/riscv: Use generic DeviceState instead of PFlashCFI01

2023-01-06 Thread Daniel Henrique Barboza
On 1/4/23 19:04, Philippe Mathieu-Daudé wrote: Nothing here requires access to PFlashCFI01 internal fields: use the inherited generic DeviceState. Signed-off-by: Philippe Mathieu-Daudé --- Reviewed-by: Daniel Henrique Barboza hw/riscv/virt.c | 9 + include/hw/riscv/v

[PATCH 06/20] hw/riscv: Use generic DeviceState instead of PFlashCFI01

2023-01-04 Thread Philippe Mathieu-Daudé
Nothing here requires access to PFlashCFI01 internal fields: use the inherited generic DeviceState. Signed-off-by: Philippe Mathieu-Daudé --- hw/riscv/virt.c | 9 + include/hw/riscv/virt.h | 3 +-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/riscv/virt.c b/h