Re: [PATCH 06/22] qapi/parser: assert get_expr returns object in outer loop

2021-04-27 Thread John Snow
On 4/25/21 3:23 AM, Markus Armbruster wrote: John Snow writes: get_expr can return many things, depending on where it is used. In the outer parsing loop, we expect and require it to return a dict. (It's (maybe) a bit involved to teach mypy that when nested is False, this is already always Tru

Re: [PATCH 06/22] qapi/parser: assert get_expr returns object in outer loop

2021-04-25 Thread Markus Armbruster
John Snow writes: > get_expr can return many things, depending on where it is used. In the > outer parsing loop, we expect and require it to return a dict. > > (It's (maybe) a bit involved to teach mypy that when nested is False, > this is already always True. I'll look into it later, maybe.) > >

[PATCH 06/22] qapi/parser: assert get_expr returns object in outer loop

2021-04-21 Thread John Snow
get_expr can return many things, depending on where it is used. In the outer parsing loop, we expect and require it to return a dict. (It's (maybe) a bit involved to teach mypy that when nested is False, this is already always True. I'll look into it later, maybe.) Signed-off-by: John Snow ---