Re: [PATCH 07/11] tcg: Clear plugin_mem_cbs on TB exit

2023-03-10 Thread Richard Henderson
On 3/10/23 09:56, Alex Bennée wrote: Richard Henderson writes: On 3/10/23 09:39, Richard Henderson wrote: +    /* Undo any setting in generated code. */ +    plugin_gen_disable_mem_helpers(); Oh! And this is the wrong function. Should be qemu_plugin_disable_mem_helpers. Did I miss a

Re: [PATCH 07/11] tcg: Clear plugin_mem_cbs on TB exit

2023-03-10 Thread Alex Bennée
Richard Henderson writes: > On 3/10/23 09:39, Richard Henderson wrote: >> +    /* Undo any setting in generated code. */ >> +    plugin_gen_disable_mem_helpers(); > > Oh! And this is the wrong function. Should be > qemu_plugin_disable_mem_helpers. Did I miss a newer version of the patches?

Re: [PATCH 07/11] tcg: Clear plugin_mem_cbs on TB exit

2023-03-10 Thread Richard Henderson
On 3/10/23 09:39, Richard Henderson wrote: +    /* Undo any setting in generated code. */ +    plugin_gen_disable_mem_helpers(); Oh! And this is the wrong function. Should be qemu_plugin_disable_mem_helpers. r~

Re: [PATCH 07/11] tcg: Clear plugin_mem_cbs on TB exit

2023-03-10 Thread Richard Henderson
On 3/10/23 02:31, Alex Bennée wrote: From: Richard Henderson Do this in cpu_tb_exec (normal exit) and cpu_loop_exit (exception), adjacent to where we reset can_do_io. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1381 Signed-off-by: Richard Henderson Message-Id:

[PATCH 07/11] tcg: Clear plugin_mem_cbs on TB exit

2023-03-10 Thread Alex Bennée
From: Richard Henderson Do this in cpu_tb_exec (normal exit) and cpu_loop_exit (exception), adjacent to where we reset can_do_io. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1381 Signed-off-by: Richard Henderson Message-Id: <20230301024737.1210851-2-richard.hender...@linaro.org>