Re: [PATCH 07/13] RFC migration: icp/server is a mess

2023-10-20 Thread Nicholas Piggin
On Fri Oct 20, 2023 at 6:33 PM AEST, Greg Kurz wrote: > On Fri, 20 Oct 2023 17:49:38 +1000 > "Nicholas Piggin" wrote: > > > On Fri Oct 20, 2023 at 7:39 AM AEST, Greg Kurz wrote: > > > On Thu, 19 Oct 2023 21:08:25 +0200 > > > Juan Quintela wrote: > > > > > > > Current code does: > > > > - register

Re: [PATCH 07/13] RFC migration: icp/server is a mess

2023-10-20 Thread Juan Quintela
Greg Kurz wrote: > On Fri, 20 Oct 2023 09:30:44 +0200 > Juan Quintela wrote: > >> Greg Kurz wrote: >> > On Thu, 19 Oct 2023 21:08:25 +0200 >> > Juan Quintela wrote: >> > >> >> Current code does: >> >> - register pre_2_10_vmstate_dummy_icp with "icp/server" and instance >> >> dependinfg on cpu

Re: [PATCH 07/13] RFC migration: icp/server is a mess

2023-10-20 Thread Greg Kurz
On Fri, 20 Oct 2023 17:49:38 +1000 "Nicholas Piggin" wrote: > On Fri Oct 20, 2023 at 7:39 AM AEST, Greg Kurz wrote: > > On Thu, 19 Oct 2023 21:08:25 +0200 > > Juan Quintela wrote: > > > > > Current code does: > > > - register pre_2_10_vmstate_dummy_icp with "icp/server" and instance > > > depe

Re: [PATCH 07/13] RFC migration: icp/server is a mess

2023-10-20 Thread Juan Quintela
"Nicholas Piggin" wrote: > On Fri Oct 20, 2023 at 7:39 AM AEST, Greg Kurz wrote: >> On Thu, 19 Oct 2023 21:08:25 +0200 >> Juan Quintela wrote: > So the reason we can't have duplicate names registered, aside from it > surely going bad if we actually send or receive a stream at the point > they a

Re: [PATCH 07/13] RFC migration: icp/server is a mess

2023-10-20 Thread Thomas Huth
On 20/10/2023 10.06, Greg Kurz wrote: On Fri, 20 Oct 2023 09:30:44 +0200 Juan Quintela wrote: Greg Kurz wrote: On Thu, 19 Oct 2023 21:08:25 +0200 Juan Quintela wrote: Current code does: - register pre_2_10_vmstate_dummy_icp with "icp/server" and instance dependinfg on cpu number - for

Re: [PATCH 07/13] RFC migration: icp/server is a mess

2023-10-20 Thread Greg Kurz
On Fri, 20 Oct 2023 09:30:44 +0200 Juan Quintela wrote: > Greg Kurz wrote: > > On Thu, 19 Oct 2023 21:08:25 +0200 > > Juan Quintela wrote: > > > >> Current code does: > >> - register pre_2_10_vmstate_dummy_icp with "icp/server" and instance > >> dependinfg on cpu number > >> - for newer machi

Re: [PATCH 07/13] RFC migration: icp/server is a mess

2023-10-20 Thread Nicholas Piggin
On Fri Oct 20, 2023 at 7:39 AM AEST, Greg Kurz wrote: > On Thu, 19 Oct 2023 21:08:25 +0200 > Juan Quintela wrote: > > > Current code does: > > - register pre_2_10_vmstate_dummy_icp with "icp/server" and instance > > dependinfg on cpu number > > - for newer machines, it register vmstate_icp with

Re: [PATCH 07/13] RFC migration: icp/server is a mess

2023-10-20 Thread Cédric Le Goater
On 10/20/23 07:10, Thomas Huth wrote: On 19/10/2023 23.15, Cédric Le Goater wrote: On 10/19/23 22:49, Greg Kurz wrote: Hi Juan, On Thu, 19 Oct 2023 21:08:25 +0200 Juan Quintela wrote: Current code does: - register pre_2_10_vmstate_dummy_icp with "icp/server" and instance    dependinfg on cp

Re: [PATCH 07/13] RFC migration: icp/server is a mess

2023-10-20 Thread Juan Quintela
Greg Kurz wrote: > On Thu, 19 Oct 2023 21:08:25 +0200 > Juan Quintela wrote: > >> Current code does: >> - register pre_2_10_vmstate_dummy_icp with "icp/server" and instance >> dependinfg on cpu number >> - for newer machines, it register vmstate_icp with "icp/server" name >> and instance 0 >>

Re: [PATCH 07/13] RFC migration: icp/server is a mess

2023-10-19 Thread Thomas Huth
On 19/10/2023 23.15, Cédric Le Goater wrote: On 10/19/23 22:49, Greg Kurz wrote: Hi Juan, On Thu, 19 Oct 2023 21:08:25 +0200 Juan Quintela wrote: Current code does: - register pre_2_10_vmstate_dummy_icp with "icp/server" and instance    dependinfg on cpu number - for newer machines, it regis

Re: [PATCH 07/13] RFC migration: icp/server is a mess

2023-10-19 Thread Greg Kurz
On Thu, 19 Oct 2023 21:08:25 +0200 Juan Quintela wrote: > Current code does: > - register pre_2_10_vmstate_dummy_icp with "icp/server" and instance > dependinfg on cpu number > - for newer machines, it register vmstate_icp with "icp/server" name > and instance 0 > - now it unregisters "icp/se

Re: [PATCH 07/13] RFC migration: icp/server is a mess

2023-10-19 Thread Cédric Le Goater
On 10/19/23 22:49, Greg Kurz wrote: Hi Juan, On Thu, 19 Oct 2023 21:08:25 +0200 Juan Quintela wrote: Current code does: - register pre_2_10_vmstate_dummy_icp with "icp/server" and instance dependinfg on cpu number - for newer machines, it register vmstate_icp with "icp/server" name and

Re: [PATCH 07/13] RFC migration: icp/server is a mess

2023-10-19 Thread Greg Kurz
Hi Juan, On Thu, 19 Oct 2023 21:08:25 +0200 Juan Quintela wrote: > Current code does: > - register pre_2_10_vmstate_dummy_icp with "icp/server" and instance > dependinfg on cpu number > - for newer machines, it register vmstate_icp with "icp/server" name > and instance 0 > - now it unregiste

[PATCH 07/13] RFC migration: icp/server is a mess

2023-10-19 Thread Juan Quintela
Current code does: - register pre_2_10_vmstate_dummy_icp with "icp/server" and instance dependinfg on cpu number - for newer machines, it register vmstate_icp with "icp/server" name and instance 0 - now it unregisters "icp/server" for the 1st instance. This is wrong at many levels: - we should