Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length

2021-02-15 Thread Cleber Rosa
On Tue, Feb 09, 2021 at 06:15:26PM +0100, Philippe Mathieu-Daudé wrote: > > > > I've actually done this with some Xen patches I'm working on at the > > moment. I'll probably decorate the test with: > > > > @skipUnless(os.getenv('AVOCADO_ALLOW_UNTRUSTED_CODE'), 'untrusted code') > > > > with a

Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length

2021-02-09 Thread Philippe Mathieu-Daudé
On 2/9/21 1:52 PM, Alex Bennée wrote: > Max Reitz writes: >> On 09.02.21 12:24, Alex Bennée wrote: >>> Max Reitz writes: On 04.02.21 14:23, Alex Bennée wrote: > Cleber Rosa writes: > ... Ideally, vmlinuz='' would be the default, but there’s a problem with that: I submitted

Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length

2021-02-09 Thread Alex Bennée
Max Reitz writes: > On 09.02.21 13:52, Alex Bennée wrote: >> >> Max Reitz writes: >> >>> On 09.02.21 12:24, Alex Bennée wrote: Max Reitz writes: > On 04.02.21 14:23, Alex Bennée wrote: >> >> Cleber Rosa writes: >> >>> If the vmlinuz variable is set to any

Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length

2021-02-09 Thread Max Reitz
On 09.02.21 13:52, Alex Bennée wrote: Max Reitz writes: On 09.02.21 12:24, Alex Bennée wrote: Max Reitz writes: On 04.02.21 14:23, Alex Bennée wrote: Cleber Rosa writes: If the vmlinuz variable is set to anything that evaluates to True, then the respective arguments should be set.

Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length

2021-02-09 Thread Alex Bennée
Max Reitz writes: > On 09.02.21 12:24, Alex Bennée wrote: >> >> Max Reitz writes: >> >>> On 04.02.21 14:23, Alex Bennée wrote: Cleber Rosa writes: > If the vmlinuz variable is set to anything that evaluates to True, > then the respective arguments should be set. If t

Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length

2021-02-09 Thread Max Reitz
On 09.02.21 12:24, Alex Bennée wrote: Max Reitz writes: On 04.02.21 14:23, Alex Bennée wrote: Cleber Rosa writes: If the vmlinuz variable is set to anything that evaluates to True, then the respective arguments should be set. If the variable contains an empty string, than it will evalua

Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length

2021-02-09 Thread Alex Bennée
Max Reitz writes: > On 04.02.21 14:23, Alex Bennée wrote: >> >> Cleber Rosa writes: >> >>> If the vmlinuz variable is set to anything that evaluates to True, >>> then the respective arguments should be set. If the variable contains >>> an empty string, than it will evaluate to False, and th

Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length

2021-02-09 Thread Max Reitz
On 04.02.21 14:23, Alex Bennée wrote: Cleber Rosa writes: If the vmlinuz variable is set to anything that evaluates to True, then the respective arguments should be set. If the variable contains an empty string, than it will evaluate to False, and the extra arguments will not be set. This k

Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length

2021-02-04 Thread Alex Bennée
Cleber Rosa writes: > If the vmlinuz variable is set to anything that evaluates to True, > then the respective arguments should be set. If the variable contains > an empty string, than it will evaluate to False, and the extra > arguments will not be set. > > This keeps the same logic, but impr

Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length

2021-02-04 Thread Beraldo Leal
On Wed, Feb 03, 2021 at 12:23:42PM -0500, Cleber Rosa wrote: > If the vmlinuz variable is set to anything that evaluates to True, > then the respective arguments should be set. If the variable contains > an empty string, than it will evaluate to False, and the extra > arguments will not be set. >

[PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length

2021-02-03 Thread Cleber Rosa
If the vmlinuz variable is set to anything that evaluates to True, then the respective arguments should be set. If the variable contains an empty string, than it will evaluate to False, and the extra arguments will not be set. This keeps the same logic, but improves readability a bit. Signed-off