Re: [PATCH 08/25] hw/i2c: add support for flexcomm i2c

2024-09-20 Thread Corey Minyard
Thanks, this all looks good to me. And FIELD() is the right way to go, as Peter said. -corey On Fri, Sep 20, 2024 at 1:03 PM Octavian Purdila wrote: > > On Thu, Sep 19, 2024 at 2:36 AM Peter Maydell > wrote: > > > > On Wed, 18 Sept 2024 at 22:31, Corey Minyard wrote: > > > Generally it's fro

Re: [PATCH 08/25] hw/i2c: add support for flexcomm i2c

2024-09-20 Thread Octavian Purdila
On Thu, Sep 19, 2024 at 2:36 AM Peter Maydell wrote: > > On Wed, 18 Sept 2024 at 22:31, Corey Minyard wrote: > > Generally it's frowned upon to have a ton of extra stuff that's not > > used. I would think some is ok, like defining bits in registers that > > aren't used yet, but I have no idea ho

Re: [PATCH 08/25] hw/i2c: add support for flexcomm i2c

2024-09-19 Thread Peter Maydell
On Wed, 18 Sept 2024 at 22:31, Corey Minyard wrote: > Generally it's frowned upon to have a ton of extra stuff that's not > used. I would think some is ok, like defining bits in registers that > aren't used yet, but I have no idea how all the enums below here > actually tie into anything. I'm gu

Re: [PATCH 08/25] hw/i2c: add support for flexcomm i2c

2024-09-18 Thread Octavian Purdila
On Wed, Sep 18, 2024 at 2:31 PM Corey Minyard wrote: > > On Wed, Sep 18, 2024 at 02:04:58PM -0700, Octavian Purdila wrote: > > On Wed, Sep 18, 2024 at 1:17???PM Corey Minyard wrote: > > > > > > On Wed, Sep 18, 2024 at 12:22:36PM -0700, Octavian Purdila wrote: > > > > Add support for NXP's flexcom

Re: [PATCH 08/25] hw/i2c: add support for flexcomm i2c

2024-09-18 Thread Corey Minyard
On Wed, Sep 18, 2024 at 02:04:58PM -0700, Octavian Purdila wrote: > On Wed, Sep 18, 2024 at 1:17???PM Corey Minyard wrote: > > > > On Wed, Sep 18, 2024 at 12:22:36PM -0700, Octavian Purdila wrote: > > > Add support for NXP's flexcomm i2c. It does not support slave mode or > > > DMA. > > > > > > Th

Re: [PATCH 08/25] hw/i2c: add support for flexcomm i2c

2024-09-18 Thread Octavian Purdila
On Wed, Sep 18, 2024 at 1:17 PM Corey Minyard wrote: > > On Wed, Sep 18, 2024 at 12:22:36PM -0700, Octavian Purdila wrote: > > Add support for NXP's flexcomm i2c. It does not support slave mode or > > DMA. > > > > The patch includes an automatically generated header which contains > > the register

Re: [PATCH 08/25] hw/i2c: add support for flexcomm i2c

2024-09-18 Thread Corey Minyard
On Wed, Sep 18, 2024 at 12:22:36PM -0700, Octavian Purdila wrote: > Add support for NXP's flexcomm i2c. It does not support slave mode or > DMA. > > The patch includes an automatically generated header which contains > the register layout and helpers. > > The header can be regenerated with the sv

[PATCH 08/25] hw/i2c: add support for flexcomm i2c

2024-09-18 Thread Octavian Purdila
Add support for NXP's flexcomm i2c. It does not support slave mode or DMA. The patch includes an automatically generated header which contains the register layout and helpers. The header can be regenerated with the svd-flexcomm-i2c target when the build is configured with --enable-mcux-soc-svd.