Re: [PATCH 08/33] target/mips: Convert MSA LDI opcode to decodetree

2021-10-23 Thread Richard Henderson
On 10/23/21 2:47 PM, Philippe Mathieu-Daudé wrote: +static bool trans_LDI(DisasContext *ctx, arg_msa_ldst *a) +{ +TCGv_i32 tdf; +TCGv_i32 twd; +TCGv_i32 timm; + +if (!check_msa_access(ctx)) { +return false; +} Return true. I won't mention the return after check_msa_

[PATCH 08/33] target/mips: Convert MSA LDI opcode to decodetree

2021-10-23 Thread Philippe Mathieu-Daudé
Convert the LDI opcode (Immediate Load) to decodetree. Since it overlaps with the generic MSA handler, use a decodetree overlap group. Since the 'data format' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tcg/