Re: [PATCH 09/16] qapi/expr.py: rewrite check_if

2020-09-24 Thread Cleber Rosa
On Tue, Sep 22, 2020 at 05:13:06PM -0400, John Snow wrote: > This is a only minor rewrite to address some minor style nits. Don't > compare against the empty list to check for the empty condition, and > move the normalization forward to unify the check on the now-normalized > structure. > >

Re: [PATCH 09/16] qapi/expr.py: rewrite check_if

2020-09-23 Thread Eduardo Habkost
On Tue, Sep 22, 2020 at 05:13:06PM -0400, John Snow wrote: > This is a only minor rewrite to address some minor style nits. Don't > compare against the empty list to check for the empty condition, and > move the normalization forward to unify the check on the now-normalized > structure. > >

[PATCH 09/16] qapi/expr.py: rewrite check_if

2020-09-22 Thread John Snow
This is a only minor rewrite to address some minor style nits. Don't compare against the empty list to check for the empty condition, and move the normalization forward to unify the check on the now-normalized structure. Signed-off-by: John Snow --- scripts/qapi/expr.py | 18 +-