Re: [PATCH 1/1] Fix qcow2 corruption on discard

2020-11-25 Thread Alberto Garcia
On Tue 24 Nov 2020 08:44:00 PM CET, Maxim Levitsky wrote: > On Tue, 2020-11-24 at 20:59 +0200, Maxim Levitsky wrote: >> On Tue, 2020-11-24 at 19:59 +0100, Alberto Garcia wrote: >> > On Tue 24 Nov 2020 10:17:23 AM CET, Kevin Wolf wrote: >> > > We can then continue work to find a minimal reproducer

Re: [PATCH 1/1] Fix qcow2 corruption on discard

2020-11-24 Thread Maxim Levitsky
On Tue, 2020-11-24 at 20:59 +0200, Maxim Levitsky wrote: > On Tue, 2020-11-24 at 19:59 +0100, Alberto Garcia wrote: > > On Tue 24 Nov 2020 10:17:23 AM CET, Kevin Wolf wrote: > > > We can then continue work to find a minimal reproducer and merge the > > > test case in the early 6.0 cycle. > > > >

Re: [PATCH 1/1] Fix qcow2 corruption on discard

2020-11-24 Thread Maxim Levitsky
On Tue, 2020-11-24 at 19:59 +0100, Alberto Garcia wrote: > On Tue 24 Nov 2020 10:17:23 AM CET, Kevin Wolf wrote: > > We can then continue work to find a minimal reproducer and merge the > > test case in the early 6.0 cycle. > > I haven't been able to reproduce the problem yet, do you have any >

Re: [PATCH 1/1] Fix qcow2 corruption on discard

2020-11-24 Thread Alberto Garcia
On Tue 24 Nov 2020 10:17:23 AM CET, Kevin Wolf wrote: > We can then continue work to find a minimal reproducer and merge the > test case in the early 6.0 cycle. I haven't been able to reproduce the problem yet, do you have any findings? Berto

Re: [PATCH 1/1] Fix qcow2 corruption on discard

2020-11-24 Thread Kevin Wolf
Am 23.11.2020 um 19:11 hat Maxim Levitsky geschrieben: > On Mon, 2020-11-23 at 18:38 +0100, Kevin Wolf wrote: > > Am 23.11.2020 um 16:49 hat Maxim Levitsky geschrieben: > > > Commit 205fa50750 ("qcow2: Add subcluster support to zero_in_l2_slice()") > > > introduced a subtle change to code in

Re: [PATCH 1/1] Fix qcow2 corruption on discard

2020-11-23 Thread Maxim Levitsky
On Mon, 2020-11-23 at 19:20 +0100, Alberto Garcia wrote: > On Mon 23 Nov 2020 05:09:41 PM CET, Kevin Wolf wrote: > > > Commit 205fa50750 ("qcow2: Add subcluster support to zero_in_l2_slice()") > > > introduced a subtle change to code in zero_in_l2_slice: > > > > > > It swapped the order of > > >

Re: [PATCH 1/1] Fix qcow2 corruption on discard

2020-11-23 Thread Alberto Garcia
On Mon 23 Nov 2020 05:09:41 PM CET, Kevin Wolf wrote: >> Commit 205fa50750 ("qcow2: Add subcluster support to zero_in_l2_slice()") >> introduced a subtle change to code in zero_in_l2_slice: >> >> It swapped the order of >> >> 1. qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice); >> 2.

Re: [PATCH 1/1] Fix qcow2 corruption on discard

2020-11-23 Thread Maxim Levitsky
On Mon, 2020-11-23 at 18:38 +0100, Kevin Wolf wrote: > Am 23.11.2020 um 16:49 hat Maxim Levitsky geschrieben: > > Commit 205fa50750 ("qcow2: Add subcluster support to zero_in_l2_slice()") > > introduced a subtle change to code in zero_in_l2_slice: > > > > It swapped the order of > > > > 1.

Re: [PATCH 1/1] Fix qcow2 corruption on discard

2020-11-23 Thread Kevin Wolf
Am 23.11.2020 um 16:49 hat Maxim Levitsky geschrieben: > Commit 205fa50750 ("qcow2: Add subcluster support to zero_in_l2_slice()") > introduced a subtle change to code in zero_in_l2_slice: > > It swapped the order of > > 1. qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice); > 2.

Re: [PATCH 1/1] Fix qcow2 corruption on discard

2020-11-23 Thread Kevin Wolf
Am 23.11.2020 um 16:49 hat Maxim Levitsky geschrieben: > Commit 205fa50750 ("qcow2: Add subcluster support to zero_in_l2_slice()") > introduced a subtle change to code in zero_in_l2_slice: > > It swapped the order of > > 1. qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice); > 2.

[PATCH 1/1] Fix qcow2 corruption on discard

2020-11-23 Thread Maxim Levitsky
Commit 205fa50750 ("qcow2: Add subcluster support to zero_in_l2_slice()") introduced a subtle change to code in zero_in_l2_slice: It swapped the order of 1. qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice); 2. set_l2_entry(s, l2_slice, l2_index + i, QCOW_OFLAG_ZERO); 3.