Re: [PATCH 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-02-19 Thread Gerd Hoffmann
Hi, > > Maybe we need a type_register_mayfail() variant which doesn't abort in > > case the parent isn't found (see also commit > > 501093207eb1ed4845e0a65ee1ce7db7b9676e0b). > > I was also thinking along the same lines last night, and came up with > this workaround: > > diff --git

Re: [PATCH 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-02-19 Thread Halil Pasic
On Fri, 19 Feb 2021 09:45:45 +0100 Gerd Hoffmann wrote: > > but that "fixes" s390x at the expense > > of breaking all the other targets. For example: > > ./qemu-system-x86_64 -device help > > Type 'virtio-gpu-ccw' is missing its parent 'virtio-ccw-device' > > Aborted > > Hmm, this is a new

Re: [PATCH 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-02-19 Thread Gerd Hoffmann
Hi, > I don't see way around target-specific modules. With the modifications > suggested by Thomas and Connie, I was able to get the new module to > compile regardless of the target, Cool (should have checked all mails before sending replies ...). > but that "fixes" s390x at the expense > of

Re: [PATCH 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-02-19 Thread Gerd Hoffmann
Hi, > I'm not against cleaning up the includes for virtio-ccw devices, but I > tend to see that as a separate, less pressing issue. Well, it would allow to build virtio-ccw as common code (i.e. move from specific_ss to softmmu_ss). > > Alternatively add support for > > target-specific modules

Re: [PATCH 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-02-18 Thread Halil Pasic
On Thu, 18 Feb 2021 14:38:20 +0100 Gerd Hoffmann wrote: > > > The explanation is simple. Unlike most devices, the ccw devices aren't > > > portable. In particular both css.c and css.h includes "cpu.h", and > > > virtio-ccw-gpu.c includes "qemu/osdep.h". Furthermore osdep.h contains: > > > #ifdef

Re: [PATCH 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-02-18 Thread Halil Pasic
On Thu, 18 Feb 2021 15:44:47 +0100 Thomas Huth wrote: > On 18/02/2021 11.34, Halil Pasic wrote: > > On Thu, 18 Feb 2021 10:23:16 +0100 > > Thomas Huth wrote: > > > >>> Since the virtio-gpu-ccw device depends on the hw-display-virtio-gpu > >>> module, which provides the type

Re: [PATCH 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-02-18 Thread Halil Pasic
On Thu, 18 Feb 2021 14:38:20 +0100 Gerd Hoffmann wrote: > Hi, > > > > The explanation is simple. Unlike most devices, the ccw devices aren't > > > portable. In particular both css.c and css.h includes "cpu.h", and > > > virtio-ccw-gpu.c includes "qemu/osdep.h". Furthermore osdep.h contains: >

Re: [PATCH 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-02-18 Thread Thomas Huth
On 18/02/2021 11.34, Halil Pasic wrote: On Thu, 18 Feb 2021 10:23:16 +0100 Thomas Huth wrote: Since the virtio-gpu-ccw device depends on the hw-display-virtio-gpu module, which provides the type virtio-gpu-device, packaging the hw-display-virtio-gpu module as a separate package that may or

Re: [PATCH 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-02-18 Thread Gerd Hoffmann
Hi, > > The explanation is simple. Unlike most devices, the ccw devices aren't > > portable. In particular both css.c and css.h includes "cpu.h", and > > virtio-ccw-gpu.c includes "qemu/osdep.h". Furthermore osdep.h contains: > > #ifdef NEED_CPU_H > > #include CONFIG_TARGET > > #else > >

Re: [PATCH 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-02-18 Thread Cornelia Huck
On Thu, 18 Feb 2021 11:34:38 +0100 Halil Pasic wrote: > On Thu, 18 Feb 2021 10:23:16 +0100 > Thomas Huth wrote: > > > > Since the virtio-gpu-ccw device depends on the hw-display-virtio-gpu > > > module, which provides the type virtio-gpu-device, packaging the > > > hw-display-virtio-gpu module

Re: [PATCH 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-02-18 Thread Halil Pasic
On Thu, 18 Feb 2021 10:23:16 +0100 Thomas Huth wrote: > > Since the virtio-gpu-ccw device depends on the hw-display-virtio-gpu > > module, which provides the type virtio-gpu-device, packaging the > > hw-display-virtio-gpu module as a separate package that may or may not > > be installed along

Re: [PATCH 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-02-18 Thread Thomas Huth
On 18/02/2021 03.22, Halil Pasic wrote: Since the virtio-gpu-ccw device depends on the hw-display-virtio-gpu module, which provides the type virtio-gpu-device, packaging the hw-display-virtio-gpu module as a separate package that may or may not be installed along with the qemu package leads to

[PATCH 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-02-17 Thread Halil Pasic
Since the virtio-gpu-ccw device depends on the hw-display-virtio-gpu module, which provides the type virtio-gpu-device, packaging the hw-display-virtio-gpu module as a separate package that may or may not be installed along with the qemu package leads to problems. Namely if the