Re: [PATCH 1/1] readline: fix hmp completion issue

2023-02-14 Thread Thomas Huth
On 07/02/2023 05.52, Dongli Zhang wrote: Subject: [PATCH 1/1] readline: fix hmp completion issue From: Dongli Zhang Date: 07/02/2023, 05.52 To: qemu-devel@nongnu.org CC: dgilb...@redhat.com, joe@oracle.com The auto completion does not work in some cases. Case 1. 1. (qemu) info reg 2

Re: [PATCH 1/1] readline: fix hmp completion issue

2023-02-08 Thread Markus Armbruster
Dongli Zhang writes: > The auto completion does not work in some cases. > > Case 1. > > 1. (qemu) info reg > 2. Press 'Tab'. > 3. It does not auto complete. > > Case 2. > > 1. (qemu) block_resize flo > 2. Press 'Tab'. > 3. It does not auto complete 'floppy0'. > > Since the readline_add_completion

Re: [PATCH 1/1] readline: fix hmp completion issue

2023-02-08 Thread Philippe Mathieu-Daudé
On 7/2/23 05:52, Dongli Zhang wrote: The auto completion does not work in some cases. Case 1. 1. (qemu) info reg 2. Press 'Tab'. 3. It does not auto complete. Case 2. 1. (qemu) block_resize flo 2. Press 'Tab'. 3. It does not auto complete 'floppy0'. Since the readline_add_completion_of() may

[PATCH 1/1] readline: fix hmp completion issue

2023-02-06 Thread Dongli Zhang
The auto completion does not work in some cases. Case 1. 1. (qemu) info reg 2. Press 'Tab'. 3. It does not auto complete. Case 2. 1. (qemu) block_resize flo 2. Press 'Tab'. 3. It does not auto complete 'floppy0'. Since the readline_add_completion_of() may add any completion when strlen(pfx) is