Re: [PATCH 1/1] virtio: fix the condition for iommu_platform not supported

2022-01-14 Thread Michael S. Tsirkin
On Fri, Jan 14, 2022 at 05:05:56PM +0100, Halil Pasic wrote: > On Thu, 13 Jan 2022 20:54:52 +0100 > Halil Pasic wrote: > > > > > This is the very reason for which commit 7ef7e6e3b ("vhost: correctly > > > > turn on VIRTIO_F_IOMMU_PLATFORM") for, which fences _F_ACCESS_PLATFORM > > > > form the vh

Re: [PATCH 1/1] virtio: fix the condition for iommu_platform not supported

2022-01-14 Thread Halil Pasic
On Thu, 13 Jan 2022 20:54:52 +0100 Halil Pasic wrote: > > > This is the very reason for which commit 7ef7e6e3b ("vhost: correctly > > > turn on VIRTIO_F_IOMMU_PLATFORM") for, which fences _F_ACCESS_PLATFORM > > > form the vhost device that does not need it, because on the vhost > > > interface it

Re: [PATCH 1/1] virtio: fix the condition for iommu_platform not supported

2022-01-13 Thread Halil Pasic
On Thu, 13 Jan 2022 12:11:42 -0500 "Michael S. Tsirkin" wrote: > On Thu, Jan 13, 2022 at 05:51:31PM +0100, Halil Pasic wrote: > > The commit 04ceb61a40 ("virtio: Fail if iommu_platform is requested, but > > unsupported") claims to fail the device hotplug when iommu_platform > > is requested, but

Re: [PATCH 1/1] virtio: fix the condition for iommu_platform not supported

2022-01-13 Thread Michael S. Tsirkin
On Thu, Jan 13, 2022 at 05:51:31PM +0100, Halil Pasic wrote: > The commit 04ceb61a40 ("virtio: Fail if iommu_platform is requested, but > unsupported") claims to fail the device hotplug when iommu_platform > is requested, but not supported by the (vhost) device. On the first > glance the condition

[PATCH 1/1] virtio: fix the condition for iommu_platform not supported

2022-01-13 Thread Halil Pasic
The commit 04ceb61a40 ("virtio: Fail if iommu_platform is requested, but unsupported") claims to fail the device hotplug when iommu_platform is requested, but not supported by the (vhost) device. On the first glance the condition for detecting that situation looks perfect, but because a certain pec