Re: [PATCH 1/2] accel: move qtest CpusAccel functions to a common location

2020-10-12 Thread Jason Andryuk
On Mon, Oct 12, 2020 at 4:23 PM Claudio Fontana wrote: > > On 10/12/20 10:07 PM, Jason Andryuk wrote: > > Move and rename accel/qtest/qtest-cpu.* files to accel/dummy/ so they > > can be re-used by Xen. > > > > Signed-off-by: Jason Andryuk > > --- > > .../qtest-cpus.c => dummy/dummy-cpus.c}

Re: [PATCH 1/2] accel: move qtest CpusAccel functions to a common location

2020-10-12 Thread Paolo Bonzini
On 12/10/20 22:40, Jason Andryuk wrote: >>> +specific_ss.add_all(when: ['CONFIG_SOFTMMU', 'CONFIG_POSIX'], if_true: >>> dummy_ss) > ... I don't really know meson, but this file is guarded by > CONFIG_POSIX? If that's true, then this ifdef can just go away. Yes, it's redundant since cpus.c was

Re: [PATCH 1/2] accel: move qtest CpusAccel functions to a common location

2020-10-12 Thread Jason Andryuk
On Mon, Oct 12, 2020 at 4:30 PM Paolo Bonzini wrote: > > On 12/10/20 22:23, Claudio Fontana wrote: > > On 10/12/20 10:07 PM, Jason Andryuk wrote: > >> Move and rename accel/qtest/qtest-cpu.* files to accel/dummy/ so they > >> can be re-used by Xen. > >> > >> Signed-off-by: Jason Andryuk > >> ---

Re: [PATCH 1/2] accel: move qtest CpusAccel functions to a common location

2020-10-12 Thread Paolo Bonzini
On 12/10/20 22:23, Claudio Fontana wrote: > On 10/12/20 10:07 PM, Jason Andryuk wrote: >> Move and rename accel/qtest/qtest-cpu.* files to accel/dummy/ so they >> can be re-used by Xen. >> >> Signed-off-by: Jason Andryuk >> --- >> .../qtest-cpus.c => dummy/dummy-cpus.c} | 22

Re: [PATCH 1/2] accel: move qtest CpusAccel functions to a common location

2020-10-12 Thread Claudio Fontana
On 10/12/20 10:07 PM, Jason Andryuk wrote: > Move and rename accel/qtest/qtest-cpu.* files to accel/dummy/ so they > can be re-used by Xen. > > Signed-off-by: Jason Andryuk > --- > .../qtest-cpus.c => dummy/dummy-cpus.c} | 22 +-- > .../qtest-cpus.h => dummy/dummy-cpus.h}

[PATCH 1/2] accel: move qtest CpusAccel functions to a common location

2020-10-12 Thread Jason Andryuk
Move and rename accel/qtest/qtest-cpu.* files to accel/dummy/ so they can be re-used by Xen. Signed-off-by: Jason Andryuk --- .../qtest-cpus.c => dummy/dummy-cpus.c} | 22 +-- .../qtest-cpus.h => dummy/dummy-cpus.h} | 10 - accel/dummy/meson.build