Re: [PATCH 1/2] audio: remove qemu_spice_audio_init()

2020-12-16 Thread Gerd Hoffmann
Hi, > > I'm wondering though how you end up with spice being enabled > > but spiceaudio driver not being available. There is no separate > > config switch so you should have both spice + spiceaudio or > > none of them ... > > Hi Gerd, > > I can reproduce this problem on my openSUSE 15.2 syste

Re: [PATCH 1/2] audio: remove qemu_spice_audio_init()

2020-12-15 Thread Volker RĂ¼melin
>>> +if (using_spice) { >>> +/* >>> + * When using spice allow the spice audio driver being picked >>> + * as default. >>> + * >>> + * Temporary hack. Using audio devices without explicit >>> + * audiodev= property is already deprecated. Same go

Re: [PATCH 1/2] audio: remove qemu_spice_audio_init()

2020-12-15 Thread dann frazier
On Tue, Dec 15, 2020 at 09:07:19AM +0100, Gerd Hoffmann wrote: > > > +if (using_spice) { > > > +/* > > > + * When using spice allow the spice audio driver being picked > > > + * as default. > > > + * > > > + * Temporary hack. Using audio devices without

Re: [PATCH 1/2] audio: remove qemu_spice_audio_init()

2020-12-15 Thread Gerd Hoffmann
> > +if (using_spice) { > > +/* > > + * When using spice allow the spice audio driver being picked > > + * as default. > > + * > > + * Temporary hack. Using audio devices without explicit > > + * audiodev= property is already deprecated. Same go

Re: [PATCH 1/2] audio: remove qemu_spice_audio_init()

2020-12-13 Thread dann frazier
On Wed, Sep 16, 2020 at 2:42 AM Gerd Hoffmann wrote: > > Handle the spice special case in audio_init instead. > > With the qemu_spice_audio_init() symbol dependency being > gone we can build spiceaudio as module. > > Signed-off-by: Gerd Hoffmann > --- > include/ui/qemu-spice.h | 1 - > audio/au

[PATCH 1/2] audio: remove qemu_spice_audio_init()

2020-09-16 Thread Gerd Hoffmann
Handle the spice special case in audio_init instead. With the qemu_spice_audio_init() symbol dependency being gone we can build spiceaudio as module. Signed-off-by: Gerd Hoffmann --- include/ui/qemu-spice.h | 1 - audio/audio.c | 16 audio/spiceaudio.c | 5