Re: [PATCH 1/2] block: nbd: Fix convert qcow2 compressed to nbd

2020-07-27 Thread Nir Soffer
On Mon, Jul 27, 2020 at 5:04 PM Eric Blake wrote: > > On 7/26/20 10:25 AM, Nir Soffer wrote: > > When converting to qcow2 compressed format, the last step is a special > > zero length compressed write, ending in call to bdrv_co_truncate(). This > > call always fail for the nbd driver since it

Re: [PATCH 1/2] block: nbd: Fix convert qcow2 compressed to nbd

2020-07-27 Thread Nir Soffer
On Mon, Jul 27, 2020 at 5:04 PM Eric Blake wrote: > > On 7/26/20 10:25 AM, Nir Soffer wrote: > > When converting to qcow2 compressed format, the last step is a special > > zero length compressed write, ending in call to bdrv_co_truncate(). This > > call always fail for the nbd driver since it

Re: [PATCH 1/2] block: nbd: Fix convert qcow2 compressed to nbd

2020-07-27 Thread Eric Blake
On 7/26/20 10:25 AM, Nir Soffer wrote: When converting to qcow2 compressed format, the last step is a special zero length compressed write, ending in call to bdrv_co_truncate(). This call always fail for the nbd driver since it does not implement fails bdrv_co_truncate(). Arguably,

Re: [PATCH 1/2] block: nbd: Fix convert qcow2 compressed to nbd

2020-07-27 Thread Max Reitz
On 26.07.20 17:25, Nir Soffer wrote: > When converting to qcow2 compressed format, the last step is a special > zero length compressed write, ending in call to bdrv_co_truncate(). This > call always fail for the nbd driver since it does not implement > bdrv_co_truncate(). > > For block devices,

[PATCH 1/2] block: nbd: Fix convert qcow2 compressed to nbd

2020-07-26 Thread Nir Soffer
When converting to qcow2 compressed format, the last step is a special zero length compressed write, ending in call to bdrv_co_truncate(). This call always fail for the nbd driver since it does not implement bdrv_co_truncate(). For block devices, which have the same limits, the call succeeds