Re: [PATCH 1/2] chardev: Propagate error from logfile opening

2021-09-06 Thread Michal Prívozník
On 8/17/21 11:54 AM, Marc-André Lureau wrote: > On Tue, Aug 17, 2021 at 12:56 PM Michal Privoznik > wrote: > >> If a chardev has a logfile the file is opened using >> qemu_open_old() which does the job, but since @errp is not >> propagated into qemu_open_internal() we lose much more accurate >> e

Re: [PATCH 1/2] chardev: Propagate error from logfile opening

2021-08-17 Thread Marc-André Lureau
On Tue, Aug 17, 2021 at 12:56 PM Michal Privoznik wrote: > If a chardev has a logfile the file is opened using > qemu_open_old() which does the job, but since @errp is not > propagated into qemu_open_internal() we lose much more accurate > error and just report "Unable to open logfile $errno". W

Re: [PATCH 1/2] chardev: Propagate error from logfile opening

2021-08-17 Thread Philippe Mathieu-Daudé
On 8/17/21 10:56 AM, Michal Privoznik wrote: > If a chardev has a logfile the file is opened using > qemu_open_old() which does the job, but since @errp is not > propagated into qemu_open_internal() we lose much more accurate > error and just report "Unable to open logfile $errno". When > using pl

[PATCH 1/2] chardev: Propagate error from logfile opening

2021-08-17 Thread Michal Privoznik
If a chardev has a logfile the file is opened using qemu_open_old() which does the job, but since @errp is not propagated into qemu_open_internal() we lose much more accurate error and just report "Unable to open logfile $errno". When using plain files, it's probably okay as nothing complex is hap