Re: [PATCH 1/2] crypto/secret: fix inconsequential errors.

2020-04-22 Thread Philippe Mathieu-Daudé
On 4/15/20 10:13 PM, Alexey Krasikov wrote: * change condition from QCRYPTO_SECRET_FORMAT_RAW to QCRYPTO_SECRET_FORMAT_BASE64 in if-operator, because this is potencial error if you add another format value. Signed-off-by: Alexey Krasikov --- crypto/secret.c | 2 +- 1 file changed, 1

Re: [PATCH 1/2] crypto/secret: fix inconsequential errors.

2020-04-22 Thread Daniel P . Berrangé
On Wed, Apr 15, 2020 at 11:13:35PM +0300, Alexey Krasikov wrote: > * change condition from QCRYPTO_SECRET_FORMAT_RAW > to QCRYPTO_SECRET_FORMAT_BASE64 in if-operator, because > this is potencial error if you add another format value. I'll drop the bullet point. > > Signed-off-by: Alexey

[PATCH 1/2] crypto/secret: fix inconsequential errors.

2020-04-15 Thread Alexey Krasikov
* change condition from QCRYPTO_SECRET_FORMAT_RAW to QCRYPTO_SECRET_FORMAT_BASE64 in if-operator, because this is potencial error if you add another format value. Signed-off-by: Alexey Krasikov --- crypto/secret.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git