Re: [PATCH 1/2] hw/arm/aspeed: Remove extraneous MemoryRegion object owner

2020-06-22 Thread Cédric Le Goater
On 6/20/20 6:28 PM, Philippe Mathieu-Daudé wrote: > I'm confused by this code, 'bmc' is created as: > > bmc = g_new0(AspeedBoardState, 1); > > Then we use it as QOM owner for different MemoryRegion objects. > But looking at memory_region_init_ram (similarly for ROM): > > void memory_region_i

[PATCH 1/2] hw/arm/aspeed: Remove extraneous MemoryRegion object owner

2020-06-20 Thread Philippe Mathieu-Daudé
I'm confused by this code, 'bmc' is created as: bmc = g_new0(AspeedBoardState, 1); Then we use it as QOM owner for different MemoryRegion objects. But looking at memory_region_init_ram (similarly for ROM): void memory_region_init_ram(MemoryRegion *mr, struct Obj