Re: [PATCH 1/2] hw/arm/virt: Consolidate GIC finalize logic

2022-12-21 Thread Alexander Graf
Hey Zengui, On 21.12.22 04:35, Zenghui Yu wrote: On 2022/12/21 7:04, Alexander Graf wrote: diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h index c7dd59d7f1..365d19f7a3 100644 --- a/include/hw/arm/virt.h +++ b/include/hw/arm/virt.h @@ -109,12 +109,12 @@ typedef enum VirtMSIControllerT

Re: [PATCH 1/2] hw/arm/virt: Consolidate GIC finalize logic

2022-12-20 Thread Zenghui Yu via
On 2022/12/21 7:04, Alexander Graf wrote: diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h index c7dd59d7f1..365d19f7a3 100644 --- a/include/hw/arm/virt.h +++ b/include/hw/arm/virt.h @@ -109,12 +109,12 @@ typedef enum VirtMSIControllerType { } VirtMSIControllerType; typedef enum Vir

[PATCH 1/2] hw/arm/virt: Consolidate GIC finalize logic

2022-12-20 Thread Alexander Graf
Up to now, the finalize_gic_version() code open coded what is essentially a support bitmap match between host/emulation environment and desired target GIC type. This open coding leads to undesirable side effects. For example, a VM with KVM and -smp 10 will automatically choose GICv3 while the same