Re: [PATCH 1/2] hw/core: Add bql_interrupt flag to CPUClass

2020-08-04 Thread Eduardo Habkost
On Sun, Aug 02, 2020 at 05:05:04PM +0100, Alex Bennée wrote: > > Eduardo Habkost writes: > > > On Fri, Jul 31, 2020 at 03:14:02PM -0400, Robert Foley wrote: > >> On Fri, 31 Jul 2020 at 13:44, Eduardo Habkost wrote: > >> > > > >> > > +static inline void cpu_class_disable_bql_interrupt(CPUClass

Re: [PATCH 1/2] hw/core: Add bql_interrupt flag to CPUClass

2020-08-02 Thread Alex Bennée
Eduardo Habkost writes: > On Fri, Jul 31, 2020 at 03:14:02PM -0400, Robert Foley wrote: >> On Fri, 31 Jul 2020 at 13:44, Eduardo Habkost wrote: >> > > >> > > +static inline void cpu_class_disable_bql_interrupt(CPUClass *cc) >> > > +{ >> > > +cc->bql_interrupt = false; >> > > +} >> > >> > C

Re: [PATCH 1/2] hw/core: Add bql_interrupt flag to CPUClass

2020-07-31 Thread Eduardo Habkost
On Fri, Jul 31, 2020 at 03:14:02PM -0400, Robert Foley wrote: > On Fri, 31 Jul 2020 at 13:44, Eduardo Habkost wrote: > > > > > > +static inline void cpu_class_disable_bql_interrupt(CPUClass *cc) > > > +{ > > > +cc->bql_interrupt = false; > > > +} > > > > Class data is not supposed to change ou

Re: [PATCH 1/2] hw/core: Add bql_interrupt flag to CPUClass

2020-07-31 Thread Robert Foley
On Fri, 31 Jul 2020 at 13:44, Eduardo Habkost wrote: > > > > +static inline void cpu_class_disable_bql_interrupt(CPUClass *cc) > > +{ > > +cc->bql_interrupt = false; > > +} > > Class data is not supposed to change outside class_init. Why do > you need this function? I don't see it being used

Re: [PATCH 1/2] hw/core: Add bql_interrupt flag to CPUClass

2020-07-31 Thread Eduardo Habkost
On Fri, Jul 31, 2020 at 08:51:26AM -0400, Robert Foley wrote: > The new flag bql_interrupt, allows the CPUClass to > determine if the BQL should be held during calls to > cpu_exec_interrupt or do_interrupt. > > This is being added in preparation for changes in > cpu_handle_interrupt, which will us

[PATCH 1/2] hw/core: Add bql_interrupt flag to CPUClass

2020-07-31 Thread Robert Foley
The new flag bql_interrupt, allows the CPUClass to determine if the BQL should be held during calls to cpu_exec_interrupt or do_interrupt. This is being added in preparation for changes in cpu_handle_interrupt, which will use this flag. Signed-off-by: Robert Foley --- hw/core/cpu.c | 1