On 6/27/22 20:52, Iris Chen wrote:
Signed-off-by: Iris Chen
---
hw/block/m25p80.c | 74 +++
1 file changed, 62 insertions(+), 12 deletions(-)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index 50b523e5b1..0156a70f5e 100644
--- a/hw/block/m25p
On [2022 Jul 01] Fri 14:23:17, Cédric Le Goater wrote:
> On 7/1/22 13:40, Francisco Iglesias wrote:
> > Hi Iris,
> >
> > Looks good, a couple of minor comments below!
> >
> > On [2022 Jun 27] Mon 11:52:33, Iris Chen wrote:
> > > Signed-off-by: Iris Chen
> > > ---
> > > hw/block/m25p80.c | 74 +
On 7/1/22 13:40, Francisco Iglesias wrote:
Hi Iris,
Looks good, a couple of minor comments below!
On [2022 Jun 27] Mon 11:52:33, Iris Chen wrote:
Signed-off-by: Iris Chen
---
hw/block/m25p80.c | 74 +++
1 file changed, 62 insertions(+), 12 deleti
Hi Iris,
Looks good, a couple of minor comments below!
On [2022 Jun 27] Mon 11:52:33, Iris Chen wrote:
> Signed-off-by: Iris Chen
> ---
> hw/block/m25p80.c | 74 +++
> 1 file changed, 62 insertions(+), 12 deletions(-)
>
> diff --git a/hw/block/m25p80
Even for a simple addition a quick intro is always nice to have.
On 6/27/22 20:52, Iris Chen wrote:
Signed-off-by: Iris Chen
Too bad that we are modeling 5 bits with 5 bools but given the layout
it makes the code easier to read. LGTM.
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
hw/
Signed-off-by: Iris Chen
---
hw/block/m25p80.c | 74 +++
1 file changed, 62 insertions(+), 12 deletions(-)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index 50b523e5b1..0156a70f5e 100644
--- a/hw/block/m25p80.c
+++ b/hw/block/m25p80.c
@@ -38,21
