RE: [PATCH 1/2] i386/cpu: Add the Intel PT capabilities checking before extend the CPUID level

2020-12-02 Thread Kang, Luwei
> -Original Message- > From: Eduardo Habkost > Sent: Wednesday, December 2, 2020 5:12 AM > To: Kang, Luwei > Cc: pbonz...@redhat.com; r...@twiddle.net; qemu-devel@nongnu.org > Subject: Re: [PATCH 1/2] i386/cpu: Add the Intel PT capabilities checking > before >

Re: [PATCH 1/2] i386/cpu: Add the Intel PT capabilities checking before extend the CPUID level

2020-12-01 Thread Eduardo Habkost
Hi, Sorry for the long delay in reviewing this. Now that 5.2 is about to be released, we can try to merge this. Comments below: On Wed, Oct 14, 2020 at 04:04:42PM +0800, Luwei Kang wrote: > The current implementation will extend the CPUID level to 0x14 if > Intel PT is enabled in the guest(in

[PATCH 1/2] i386/cpu: Add the Intel PT capabilities checking before extend the CPUID level

2020-10-14 Thread Luwei Kang
The current implementation will extend the CPUID level to 0x14 if Intel PT is enabled in the guest(in x86_cpu_expand_features()) and the Intel PT will be disabled if it can't pass the capabilities checking later(in x86_cpu_filter_features()). In this case, the level of CPUID will be still 0x14 and