Re: [PATCH 1/2] i386: reorder call to cpu_exec_realizefn in x86_cpu_realizefn

2021-06-03 Thread Eduardo Habkost
On Thu, Jun 03, 2021 at 10:13:30AM +0200, Claudio Fontana wrote: > On 6/1/21 8:48 PM, Eduardo Habkost wrote: > > +Vitaly > > > > On Sat, May 29, 2021 at 11:13:12AM +0200, Claudio Fontana wrote: > >> we need to expand features first, before we attempt to check them > >> in the accel realizefn code

Re: [PATCH 1/2] i386: reorder call to cpu_exec_realizefn in x86_cpu_realizefn

2021-06-03 Thread Vitaly Kuznetsov
Eduardo Habkost writes: >> >> diff --git a/target/i386/cpu.c b/target/i386/cpu.c >> index 9e211ac2ce..6bcb7dbc2c 100644 >> --- a/target/i386/cpu.c >> +++ b/target/i386/cpu.c >> @@ -6133,34 +6133,6 @@ static void x86_cpu_realizefn(DeviceState *dev, Error >> **errp) >> Error *local_err =

Re: [PATCH 1/2] i386: reorder call to cpu_exec_realizefn in x86_cpu_realizefn

2021-06-03 Thread Claudio Fontana
On 6/1/21 8:48 PM, Eduardo Habkost wrote: > +Vitaly > > On Sat, May 29, 2021 at 11:13:12AM +0200, Claudio Fontana wrote: >> we need to expand features first, before we attempt to check them >> in the accel realizefn code called by cpu_exec_realizefn(). >> >> At the same time we need checks for

Re: [PATCH 1/2] i386: reorder call to cpu_exec_realizefn in x86_cpu_realizefn

2021-06-01 Thread Eduardo Habkost
+Vitaly On Sat, May 29, 2021 at 11:13:12AM +0200, Claudio Fontana wrote: > we need to expand features first, before we attempt to check them > in the accel realizefn code called by cpu_exec_realizefn(). > > At the same time we need checks for code_urev and host_cpuid_required, > and

[PATCH 1/2] i386: reorder call to cpu_exec_realizefn in x86_cpu_realizefn

2021-05-29 Thread Claudio Fontana
we need to expand features first, before we attempt to check them in the accel realizefn code called by cpu_exec_realizefn(). At the same time we need checks for code_urev and host_cpuid_required, and modifications to cpu->mwait to happen after the initial setting of them inside the accel