Re: [PATCH 1/2] migration: Implement dirty ring

2024-06-25 Thread Peter Xu
On Tue, Jun 25, 2024 at 08:10:23PM +0900, Shota Imamura wrote: > Dear Peter Xu, > > Thank you for your feedback. > > > It looks like this patch will introduce a ring but still it keeps the > > bitmaps around. > > > > Could you elaborate your motivation of this work? It’ll be interesting to > > kn

Re: [PATCH 1/2] migration: Implement dirty ring

2024-06-25 Thread Shota Imamura
Dear Peter Xu, Thank you for your feedback. > It looks like this patch will introduce a ring but still it keeps the > bitmaps around. > > Could you elaborate your motivation of this work? It’ll be interesting to > know whether you did any kind of measurement around it. First of all, I apologize

Re: [PATCH 1/2] migration: Implement dirty ring

2024-06-24 Thread Peter Xu
Hi, Shota, On Thu, Jun 20, 2024 at 06:47:13PM +0900, Shota Imamura wrote: > This commit implements the dirty ring as an alternative dirty tracking > method to the dirty bitmap. > > While the dirty ring has already been implemented in accel/kvm using KVM's > dirty ring, it was designed to set bits

[PATCH 1/2] migration: Implement dirty ring

2024-06-20 Thread Shota Imamura
This commit implements the dirty ring as an alternative dirty tracking method to the dirty bitmap. While the dirty ring has already been implemented in accel/kvm using KVM's dirty ring, it was designed to set bits in the ramlist and ramblock bitmap. This commit introduces a new dirty ring to repla