Re: [PATCH 1/2] riscv: Add sifive test device to sifive_e target

2020-10-24 Thread Keith Packard
Alistair Francis writes: > The sifive_u and sifive_e model real hardware (the names are confusing > I agree) so I would rather not add a virtual device. That seems reasonable; semihosting will be a much better solution for the long term anyways. I posted this because we've been maintaining it

Re: [PATCH 1/2] riscv: Add sifive test device to sifive_e target

2020-10-23 Thread Alistair Francis
On Fri, Oct 23, 2020 at 5:13 PM Keith Packard wrote: > > Alistair Francis writes: > > > I don't see this mentioned in the FE310 data sheet. Is it included in > > the hardware? > > This is strictly a virtual device used to support 'power off' when > running under QEMU. We need either this or

Re: [PATCH 1/2] riscv: Add sifive test device to sifive_e target

2020-10-23 Thread Keith Packard
Alistair Francis writes: > I don't see this mentioned in the FE310 data sheet. Is it included in > the hardware? This is strictly a virtual device used to support 'power off' when running under QEMU. We need either this or semihosting support for doing automated testing. Our tests currently use

Re: [PATCH 1/2] riscv: Add sifive test device to sifive_e target

2020-10-23 Thread Alistair Francis
On Fri, Oct 23, 2020 at 2:45 PM Keith Packard via wrote: > > The SiFive test device provides a mechanism for terminating the qemu > instance from the emulated system. This patch adds that device to the > sifive_e target. > > Signed-off-by: Keith Packard > --- > hw/riscv/sifive_e.c | 4

[PATCH 1/2] riscv: Add sifive test device to sifive_e target

2020-10-23 Thread Keith Packard via
The SiFive test device provides a mechanism for terminating the qemu instance from the emulated system. This patch adds that device to the sifive_e target. Signed-off-by: Keith Packard --- hw/riscv/sifive_e.c | 4 include/hw/riscv/sifive_e.h | 1 + 2 files changed, 5 insertions(+)