Re: [PATCH 1/2] target/arm: Fix float16 pairwise Neon ops on big-endian hosts

2020-11-02 Thread Philippe Mathieu-Daudé
On 10/28/20 8:45 PM, Philippe Mathieu-Daudé wrote: > On 10/28/20 8:17 PM, Peter Maydell wrote: >> In the neon_padd/pmax/pmin helpers for float16, a cut-and-paste error >> meant we were using the H4() address swizzler macro rather than the >> H2() which is required for 2-byte data. This had no effe

Re: [PATCH 1/2] target/arm: Fix float16 pairwise Neon ops on big-endian hosts

2020-10-28 Thread Philippe Mathieu-Daudé
On 10/28/20 8:17 PM, Peter Maydell wrote: > In the neon_padd/pmax/pmin helpers for float16, a cut-and-paste error > meant we were using the H4() address swizzler macro rather than the > H2() which is required for 2-byte data. This had no effect on > little-endian hosts but meant we put the result

[PATCH 1/2] target/arm: Fix float16 pairwise Neon ops on big-endian hosts

2020-10-28 Thread Peter Maydell
In the neon_padd/pmax/pmin helpers for float16, a cut-and-paste error meant we were using the H4() address swizzler macro rather than the H2() which is required for 2-byte data. This had no effect on little-endian hosts but meant we put the result data into the destination Dreg in the wrong order