Re: [PATCH 1/2] target/arm: add support for FEAT_DIT, Data Independent Timing

2020-12-14 Thread Peter Maydell
On Mon, 14 Dec 2020 at 18:11, Rebecca Cran wrote: > > On 12/11/20 2:37 PM, Peter Maydell wrote: > > On Fri, 11 Dec 2020 at 19:51, Richard Henderson > > wrote: > >> I'll let Peter weigh in, but I think it makes sense to move the SS bit > >> somewhere else (e.g. env->pstate) and merge it into SPSR_

Re: [PATCH 1/2] target/arm: add support for FEAT_DIT, Data Independent Timing

2020-12-14 Thread Rebecca Cran
On 12/11/20 2:37 PM, Peter Maydell wrote: On Fri, 11 Dec 2020 at 19:51, Richard Henderson wrote: I'll let Peter weigh in, but I think it makes sense to move the SS bit somewhere else (e.g. env->pstate) and merge it into SPSR_ELx upon interrupt. While what we're doing here is convenient, it's no

Re: [PATCH 1/2] target/arm: add support for FEAT_DIT, Data Independent Timing

2020-12-11 Thread Peter Maydell
On Fri, 11 Dec 2020 at 19:51, Richard Henderson wrote: > > On 12/11/20 1:33 PM, Rebecca Cran wrote: > > Is the comment in target/arm/op_helper.c:397 still relevant? > > > > uint32_t HELPER(cpsr_read)(CPUARMState *env) > > { > > /* > > * We store the ARMv8 PSTATE.SS bit in env->uncached_cp

Re: [PATCH 1/2] target/arm: add support for FEAT_DIT, Data Independent Timing

2020-12-11 Thread Rebecca Cran
On 12/11/20 7:08 AM, Richard Henderson wrote: Alternately, or additionally, TCG is outside of the security domain (only hardware accelerators like KVM are inside), and so we may implement this as a NOP. Thanks for the feedback, I'll send a v2 patch next week. Is the comment in target/arm/op_

Re: [PATCH 1/2] target/arm: add support for FEAT_DIT, Data Independent Timing

2020-12-11 Thread Richard Henderson
On 12/11/20 1:33 PM, Rebecca Cran wrote: > Is the comment in target/arm/op_helper.c:397 still relevant? > > uint32_t HELPER(cpsr_read)(CPUARMState *env) > { >     /* > * We store the ARMv8 PSTATE.SS bit in env->uncached_cpsr. > * This is convenient for populating SPSR_ELx, but must be >

Re: [PATCH 1/2] target/arm: add support for FEAT_DIT, Data Independent Timing

2020-12-11 Thread Richard Henderson
On 12/10/20 11:13 PM, Rebecca Cran wrote: > Add support for FEAT_DIT. DIT (Data Independent Timing) is a required > feature for ARMv8.4. Since virtual machine execution is largely > nondeterministic, it's implemented as a NOP. Alternately, or additionally, TCG is outside of the security domain (on

[PATCH 1/2] target/arm: add support for FEAT_DIT, Data Independent Timing

2020-12-10 Thread Rebecca Cran
Add support for FEAT_DIT. DIT (Data Independent Timing) is a required feature for ARMv8.4. Since virtual machine execution is largely nondeterministic, it's implemented as a NOP. Signed-off-by: Rebecca Cran --- target/arm/cpu.h | 20 +- target/arm/helper.c| 28 +