Re: [PATCH 1/4] plugins: fix optimization in plugin_gen_disable_mem_helpers

2023-01-10 Thread Aaron Lindsay
On Jan 08 11:47, Emilio Cota wrote: > We were mistakenly checking tcg_ctx->plugin_insn as a canary to know > whether the TB had emitted helpers that might have accessed memory. > > The problem is that tcg_ctx->plugin_insn gets updated on every > instruction in the TB, which results in us wrongly p

[PATCH 1/4] plugins: fix optimization in plugin_gen_disable_mem_helpers

2023-01-08 Thread Emilio Cota
We were mistakenly checking tcg_ctx->plugin_insn as a canary to know whether the TB had emitted helpers that might have accessed memory. The problem is that tcg_ctx->plugin_insn gets updated on every instruction in the TB, which results in us wrongly performing the optimization (i.e. not clearing