Re: [PATCH 1/5] hw/i2c: pmbus add support for block receive

2023-03-30 Thread Titus Rwantare
Apologies. I've updated the commit descriptions and added a sensor using this code in v2. While doing block receive I discovered that it is valid behaviour to erase a field and have it be an empty string. -Titus On Thu, 30 Mar 2023 at 09:18, Corey Minyard wrote: > It's generally frowned upon

Re: [PATCH 1/5] hw/i2c: pmbus add support for block receive

2023-03-30 Thread Corey Minyard
It's generally frowned upon to have empty descriptions, some rationale would be helpful. For instance, you remove a length check from the send string, why did you do that? Any why is this being added? What's it supporting? -corey On Wed, Mar 22, 2023 at 05:55:09PM +, Titus Rwantare wrote:

[PATCH 1/5] hw/i2c: pmbus add support for block receive

2023-03-22 Thread Titus Rwantare
Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/i2c/pmbus_device.c | 30 +- include/hw/i2c/pmbus_device.h | 7 +++ 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c index