Re: [PATCH 1/5] target/riscv: Ignore the S and U letters when formatting ISA strings

2022-08-08 Thread Conor.Dooley
On 08/08/2022 21:51, Alistair Francis wrote: > On Tue, Aug 9, 2022 at 2:14 AM wrote: >> I guess this patch can then be safely ignored :) >> Glad to have cleared this up as I was rather confused by what I saw. > > Great! Do you mind resending the series then with this patch dropped? > It just make

Re: [PATCH 1/5] target/riscv: Ignore the S and U letters when formatting ISA strings

2022-08-08 Thread Alistair Francis
On Tue, Aug 9, 2022 at 2:14 AM wrote: > > On 08/08/2022 16:03, Tsukasa OI wrote: > > I agree with Alistair. **I** removed 'S' and 'U' from the ISA string > > and it should be working in the latest development branch (I tested). > > Yeah, I saw what you as I looked at the commit log while trying t

Re: [PATCH 1/5] target/riscv: Ignore the S and U letters when formatting ISA strings

2022-08-08 Thread Conor.Dooley
On 08/08/2022 16:03, Tsukasa OI wrote: > I agree with Alistair. **I** removed 'S' and 'U' from the ISA string > and it should be working in the latest development branch (I tested). Yeah, I saw what you as I looked at the commit log while trying to understand why there were invalid strings appear

Re: [PATCH 1/5] target/riscv: Ignore the S and U letters when formatting ISA strings

2022-08-08 Thread Tsukasa OI
On 2022/08/06 0:54, Conor Dooley wrote: > From: Palmer Dabbelt > > The ISA strings we're providing from QEMU aren't actually legal RISC-V > ISA strings, as both S and U cannot exist as single-letter extensions > and must instead be multi-letter strings. We're still using the ISA > strings inside

Re: [PATCH 1/5] target/riscv: Ignore the S and U letters when formatting ISA strings

2022-08-08 Thread Conor.Dooley
On 07/08/2022 23:53, Alistair Francis wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Sat, Aug 6, 2022 at 2:08 AM Conor Dooley wrote: >> >> From: Palmer Dabbelt >> >> The ISA strings we're providing from QEMU aren't actually legal RIS

Re: [PATCH 1/5] target/riscv: Ignore the S and U letters when formatting ISA strings

2022-08-07 Thread Alistair Francis
On Sat, Aug 6, 2022 at 2:08 AM Conor Dooley wrote: > > From: Palmer Dabbelt > > The ISA strings we're providing from QEMU aren't actually legal RISC-V > ISA strings, as both S and U cannot exist as single-letter extensions > and must instead be multi-letter strings. We're still using the ISA > s

[PATCH 1/5] target/riscv: Ignore the S and U letters when formatting ISA strings

2022-08-05 Thread Conor Dooley
From: Palmer Dabbelt The ISA strings we're providing from QEMU aren't actually legal RISC-V ISA strings, as both S and U cannot exist as single-letter extensions and must instead be multi-letter strings. We're still using the ISA strings inside QEMU to track the availiable extensions, so just st