Re: [PATCH 1/5] tests/qtest/ipmi-kcs: Fix assert side-effect

2020-09-02 Thread Thomas Huth
On 02/09/2020 10.07, Philippe Mathieu-Daudé wrote: > Fix assert side-effect reported by Coverity: > > /qemu/tests/qtest/ipmi-kcs-test.c: 84 in kcs_wait_obf() > 83 while (IPMI_KCS_CMDREG_GET_OBF() == 0) { > >>> CID 1432368: Incorrect expression (ASSERT_SIDE_EFFECT) > >>> A

Re: [PATCH 1/5] tests/qtest/ipmi-kcs: Fix assert side-effect

2020-09-02 Thread Greg Kurz
On Wed, 2 Sep 2020 10:07:57 +0200 Philippe Mathieu-Daudé wrote: > Fix assert side-effect reported by Coverity: > > /qemu/tests/qtest/ipmi-kcs-test.c: 84 in kcs_wait_obf() > 83 while (IPMI_KCS_CMDREG_GET_OBF() == 0) { > >>> CID 1432368: Incorrect expression (ASSERT_SIDE_EFFEC

[PATCH 1/5] tests/qtest/ipmi-kcs: Fix assert side-effect

2020-09-02 Thread Philippe Mathieu-Daudé
Fix assert side-effect reported by Coverity: /qemu/tests/qtest/ipmi-kcs-test.c: 84 in kcs_wait_obf() 83 while (IPMI_KCS_CMDREG_GET_OBF() == 0) { >>> CID 1432368: Incorrect expression (ASSERT_SIDE_EFFECT) >>> Argument "--count" of g_assert() has a side effect. The contain