Re: [PATCH 1/6] block: Drop BDS comment regarding bdrv_append()

2021-06-19 Thread Vladimir Sementsov-Ogievskiy
17.06.2021 18:52, Max Reitz wrote: There is a comment above the BDS definition stating care must be taken to consider handling newly added fields in bdrv_append(). Actually, this comment should have said "bdrv_swap()" as of 4ddc07cac (nine years ago), and in any case, bdrv_swap() was dropped in

Re: [PATCH 1/6] block: Drop BDS comment regarding bdrv_append()

2021-06-18 Thread Eric Blake
On Thu, Jun 17, 2021 at 05:52:42PM +0200, Max Reitz wrote: > There is a comment above the BDS definition stating care must be taken > to consider handling newly added fields in bdrv_append(). > > Actually, this comment should have said "bdrv_swap()" as of 4ddc07cac > (nine years ago), and in any

[PATCH 1/6] block: Drop BDS comment regarding bdrv_append()

2021-06-17 Thread Max Reitz
There is a comment above the BDS definition stating care must be taken to consider handling newly added fields in bdrv_append(). Actually, this comment should have said "bdrv_swap()" as of 4ddc07cac (nine years ago), and in any case, bdrv_swap() was dropped in 8e419aefa (six years ago). So no