Re: [PATCH 1/8] target/ppc: Print out literal exception names in logs

2021-12-23 Thread Richard Henderson
On 12/21/21 10:40 PM, Cédric Le Goater wrote: +static inline const char *powerpc_excp_name(int excp) Drop the inline. It's not performance critical; let the compiler decide. Otherwise, Reviewed-by: Richard Henderson r~

Re: [PATCH 1/8] target/ppc: Print out literal exception names in logs

2021-12-22 Thread David Gibson
On Wed, Dec 22, 2021 at 07:40:18AM +0100, Cédric le Goater wrote: > It facilitates reading the logs when mask CPU_LOG_INT is activated. We > should do the same for error codes. > > Cc: Fabiano Rosas > Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson > --- > target/ppc/excp_helper.c

Re: [PATCH 1/8] target/ppc: Print out literal exception names in logs

2021-12-22 Thread Fabiano Rosas
Cédric Le Goater writes: > It facilitates reading the logs when mask CPU_LOG_INT is activated. We > should do the same for error codes. > > Cc: Fabiano Rosas > Signed-off-by: Cédric Le Goater Reviewed-by: Fabiano Rosas

[PATCH 1/8] target/ppc: Print out literal exception names in logs

2021-12-21 Thread Cédric Le Goater
It facilitates reading the logs when mask CPU_LOG_INT is activated. We should do the same for error codes. Cc: Fabiano Rosas Signed-off-by: Cédric Le Goater --- target/ppc/excp_helper.c | 75 +++- 1 file changed, 74 insertions(+), 1 deletion(-) diff --git a/