Re: [PATCH 1/9] hw/watchdog/wdt_aspeed: Map the whole MMIO range

2023-01-02 Thread Cédric Le Goater
On 12/30/22 08:32, Philippe Mathieu-Daudé wrote: On 29/12/22 21:42, Peter Delevoryas wrote: On Thu, Dec 29, 2022 at 04:23:17PM +0100, Philippe Mathieu-Daudé wrote: Avoid confusing two different things: - the WDT I/O region size ('iosize') - at which offset the SoC map the WDT ('offset') While i

Re: [PATCH 1/9] hw/watchdog/wdt_aspeed: Map the whole MMIO range

2023-01-02 Thread Cédric Le Goater
On 12/29/22 16:23, Philippe Mathieu-Daudé wrote: Avoid confusing two different things: - the WDT I/O region size ('iosize') - at which offset the SoC map the WDT ('offset') While it is often the same, we can map smaller region sizes at larger offsets. Here we are interested in the I/O region siz

Re: [PATCH 1/9] hw/watchdog/wdt_aspeed: Map the whole MMIO range

2022-12-29 Thread Philippe Mathieu-Daudé
On 29/12/22 21:42, Peter Delevoryas wrote: On Thu, Dec 29, 2022 at 04:23:17PM +0100, Philippe Mathieu-Daudé wrote: Avoid confusing two different things: - the WDT I/O region size ('iosize') - at which offset the SoC map the WDT ('offset') While it is often the same, we can map smaller region siz

Re: [PATCH 1/9] hw/watchdog/wdt_aspeed: Map the whole MMIO range

2022-12-29 Thread Peter Delevoryas
On Thu, Dec 29, 2022 at 04:23:17PM +0100, Philippe Mathieu-Daudé wrote: > Avoid confusing two different things: > - the WDT I/O region size ('iosize') > - at which offset the SoC map the WDT ('offset') > While it is often the same, we can map smaller region sizes at > larger offsets. > > Here we a

[PATCH 1/9] hw/watchdog/wdt_aspeed: Map the whole MMIO range

2022-12-29 Thread Philippe Mathieu-Daudé
Avoid confusing two different things: - the WDT I/O region size ('iosize') - at which offset the SoC map the WDT ('offset') While it is often the same, we can map smaller region sizes at larger offsets. Here we are interested in the I/O region size. Rename as 'iosize' and map the whole range, not