Re: [PATCH 10/16] vfio/pci: Make vfio_populate_device() return a bool

2024-05-21 Thread Cédric Le Goater
On 5/15/24 10:20, Zhenzhong Duan wrote: Since vfio_populate_device() takes an 'Error **' argument, best practices suggest to return a bool. See the qapi/error.h Rules section. Signed-off-by: Zhenzhong Duan --- hw/vfio/pci.c | 19 ++- 1 file changed, 10 insertions(+), 9

[PATCH 10/16] vfio/pci: Make vfio_populate_device() return a bool

2024-05-15 Thread Zhenzhong Duan
Since vfio_populate_device() takes an 'Error **' argument, best practices suggest to return a bool. See the qapi/error.h Rules section. Signed-off-by: Zhenzhong Duan --- hw/vfio/pci.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/hw/vfio/pci.c