Re: [PATCH 10/22] qapi: Convert simple union TransactionAction to flat one

2021-09-16 Thread Hanna Reitz
On 13.09.21 14:39, Markus Armbruster wrote: Simple unions predate flat unions. Having both complicates the QAPI schema language and the QAPI generator. We haven't been using simple unions in new code for a long time, because they are less flexible and somewhat awkward on the wire. To prepare

Re: [PATCH 10/22] qapi: Convert simple union TransactionAction to flat one

2021-09-13 Thread Markus Armbruster
Eric Blake writes: > On Mon, Sep 13, 2021 at 02:39:20PM +0200, Markus Armbruster wrote: >> Simple unions predate flat unions. Having both complicates the QAPI >> schema language and the QAPI generator. We haven't been using simple >> unions in new code for a long time, because they are less

Re: [PATCH 10/22] qapi: Convert simple union TransactionAction to flat one

2021-09-13 Thread Eric Blake
On Mon, Sep 13, 2021 at 02:39:20PM +0200, Markus Armbruster wrote: > Simple unions predate flat unions. Having both complicates the QAPI > schema language and the QAPI generator. We haven't been using simple > unions in new code for a long time, because they are less flexible and > somewhat

[PATCH 10/22] qapi: Convert simple union TransactionAction to flat one

2021-09-13 Thread Markus Armbruster
Simple unions predate flat unions. Having both complicates the QAPI schema language and the QAPI generator. We haven't been using simple unions in new code for a long time, because they are less flexible and somewhat awkward on the wire. To prepare for their removal, convert simple union