RE: [PATCH 11/15] target: Use ArchCPU as interface to target CPU

2022-02-10 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Thursday, February 10, 2022 7:22 PM > To: Taylor Simpson ; Philippe Mathieu-Daudé > ; qemu-devel@nongnu.org > Cc: Paolo Bonzini ; Thomas Huth > > Subject: Re: [PATCH 11/15] target: Use ArchCPU as interface to

Re: [PATCH 11/15] target: Use ArchCPU as interface to target CPU

2022-02-10 Thread Richard Henderson
On 2/11/22 04:35, Taylor Simpson wrote: -#define HEXAGON_CPU_CLASS(klass) \ -OBJECT_CLASS_CHECK(HexagonCPUClass, (klass), TYPE_HEXAGON_CPU) -#define HEXAGON_CPU(obj) \ -OBJECT_CHECK(HexagonCPU, (obj), TYPE_HEXAGON_CPU) -#define HEXAGON_CPU_GET_CLASS(obj) \ -OBJECT_GET_CLASS(HexagonCPU

RE: [PATCH 11/15] target: Use ArchCPU as interface to target CPU

2022-02-10 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, February 9, 2022 4:48 PM > To: Philippe Mathieu-Daudé ; qemu-devel@nongnu.org > Cc: Paolo Bonzini ; Thomas Huth > ; Taylor Simpson > Subject: Re: [PATCH 11/15] target: Use ArchCPU as interface to ta

Re: [PATCH 11/15] target: Use ArchCPU as interface to target CPU

2022-02-09 Thread Richard Henderson
On 2/10/22 09:33, Philippe Mathieu-Daudé wrote: -struct ArchCPU { +typedef struct ArchCPU { /*< private >*/ CPUState parent_obj; /*< public >*/ @@ -188,7 +188,7 @@ struct ArchCPU { uint32_t reset_addr; uint32_t exception_addr; uint32_t fast_tlb_miss_addr; -}; +

Re: [PATCH 11/15] target: Use ArchCPU as interface to target CPU

2022-02-09 Thread Richard Henderson
On 2/10/22 08:54, Philippe Mathieu-Daudé wrote: diff --git a/target/hexagon/cpu.h b/target/hexagon/cpu.h index 25c67e43a2..4dce40a360 100644 --- a/target/hexagon/cpu.h +++ b/target/hexagon/cpu.h @@ -143,7 +143,7 @@ typedef struct HexagonCPUClass { DeviceReset parent_reset; } HexagonCPUCla

Re: [PATCH 11/15] target: Use ArchCPU as interface to target CPU

2022-02-09 Thread Philippe Mathieu-Daudé via
On 9/2/22 22:54, Philippe Mathieu-Daudé wrote: ArchCPU is our interface with target-specific code. Use it as a forward-declared opaque pointer (abstract type), having its structure defined by each target. Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/typedefs.h | 1 + target/al

[PATCH 11/15] target: Use ArchCPU as interface to target CPU

2022-02-09 Thread Philippe Mathieu-Daudé via
ArchCPU is our interface with target-specific code. Use it as a forward-declared opaque pointer (abstract type), having its structure defined by each target. Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/typedefs.h | 1 + target/alpha/cpu-qom.h | 4 +++- target/alpha/cpu.h