Re: [PATCH 11/19] qapi/schema: fix QAPISchemaArrayType.check's call to resolve_type

2024-01-11 Thread John Snow
On Thu, Jan 11, 2024 at 4:33 AM Markus Armbruster wrote: > > John Snow writes: > > > On Thu, Nov 23, 2023, 8:03 AM Markus Armbruster wrote: > > > >> John Snow writes: > >> > >> > On Wed, Nov 22, 2023 at 7:59 AM Markus Armbruster > >> > wrote: > >> >> > >> >> John Snow writes: > >> >> > >>

Re: [PATCH 11/19] qapi/schema: fix QAPISchemaArrayType.check's call to resolve_type

2024-01-11 Thread Markus Armbruster
John Snow writes: > On Thu, Nov 23, 2023, 8:03 AM Markus Armbruster wrote: > >> John Snow writes: >> >> > On Wed, Nov 22, 2023 at 7:59 AM Markus Armbruster >> > wrote: >> >> >> >> John Snow writes: >> >> >> >> > There's more conditionals in here than we can reasonably pack into a >> >> >

Re: [PATCH 11/19] qapi/schema: fix QAPISchemaArrayType.check's call to resolve_type

2024-01-10 Thread John Snow
On Thu, Nov 23, 2023, 8:03 AM Markus Armbruster wrote: > John Snow writes: > > > On Wed, Nov 22, 2023 at 7:59 AM Markus Armbruster > wrote: > >> > >> John Snow writes: > >> > >> > There's more conditionals in here than we can reasonably pack into a > >> > terse little statement, so break it

Re: [PATCH 11/19] qapi/schema: fix QAPISchemaArrayType.check's call to resolve_type

2023-11-23 Thread Markus Armbruster
John Snow writes: > On Wed, Nov 22, 2023 at 7:59 AM Markus Armbruster wrote: >> >> John Snow writes: >> >> > There's more conditionals in here than we can reasonably pack into a >> > terse little statement, so break it apart into something more explicit. >> > >> > (When would a built-in array

Re: [PATCH 11/19] qapi/schema: fix QAPISchemaArrayType.check's call to resolve_type

2023-11-22 Thread John Snow
On Wed, Nov 22, 2023 at 7:59 AM Markus Armbruster wrote: > > John Snow writes: > > > There's more conditionals in here than we can reasonably pack into a > > terse little statement, so break it apart into something more explicit. > > > > (When would a built-in array ever cause a QAPISemError? I

Re: [PATCH 11/19] qapi/schema: fix QAPISchemaArrayType.check's call to resolve_type

2023-11-22 Thread Markus Armbruster
John Snow writes: > There's more conditionals in here than we can reasonably pack into a > terse little statement, so break it apart into something more explicit. > > (When would a built-in array ever cause a QAPISemError? I don't know, > maybe never - but the type system wasn't happy all the

[PATCH 11/19] qapi/schema: fix QAPISchemaArrayType.check's call to resolve_type

2023-11-15 Thread John Snow
There's more conditionals in here than we can reasonably pack into a terse little statement, so break it apart into something more explicit. (When would a built-in array ever cause a QAPISemError? I don't know, maybe never - but the type system wasn't happy all the same.) Signed-off-by: John