Re: [PATCH 12/13] target/arm: Correct definition of PMCRDP

2020-02-11 Thread Philippe Mathieu-Daudé
On 2/11/20 6:37 PM, Peter Maydell wrote: The PMCR_EL0.DP bit is bit 5, which is 0x20, not 0x10. 0x10 is 'X'. Correct our #define of PMCRDP and add the missing PMCRX. We do have the correct behaviour for handling the DP bit being set, so this fixes a guest-visible bug. Fixes: 033614c47de Revi

Re: [PATCH 12/13] target/arm: Correct definition of PMCRDP

2020-02-11 Thread Richard Henderson
On 2/11/20 9:37 AM, Peter Maydell wrote: > The PMCR_EL0.DP bit is bit 5, which is 0x20, not 0x10. 0x10 is 'X'. > Correct our #define of PMCRDP and add the missing PMCRX. > > We do have the correct behaviour for handling the DP bit being > set, so this fixes a guest-visible bug. > > Signed-off-by

[PATCH 12/13] target/arm: Correct definition of PMCRDP

2020-02-11 Thread Peter Maydell
The PMCR_EL0.DP bit is bit 5, which is 0x20, not 0x10. 0x10 is 'X'. Correct our #define of PMCRDP and add the missing PMCRX. We do have the correct behaviour for handling the DP bit being set, so this fixes a guest-visible bug. Signed-off-by: Peter Maydell --- target/arm/helper.c | 3 ++- 1 fi