Re: [PATCH 12/14] migration/multifd: multifd_send_prepare_header()

2024-02-01 Thread Peter Xu
On Wed, Jan 31, 2024 at 06:32:54PM -0300, Fabiano Rosas wrote: > > +if (!use_zero_copy_send) { > > +/* > > + * Only !zero_copy needs the header in IOV; zerocopy will > > + * send it separately. > > Could use the same spelling for both

Re: [PATCH 12/14] migration/multifd: multifd_send_prepare_header()

2024-01-31 Thread Fabiano Rosas
pet...@redhat.com writes: > From: Peter Xu > > Introduce a helper multifd_send_prepare_header() to setup the header packet > for multifd sender. > > It's fine to setup the IOV[0] _before_ send_prepare() because the packet > buffer is already ready, even if the content is to be filled in. > >

[PATCH 12/14] migration/multifd: multifd_send_prepare_header()

2024-01-31 Thread peterx
From: Peter Xu Introduce a helper multifd_send_prepare_header() to setup the header packet for multifd sender. It's fine to setup the IOV[0] _before_ send_prepare() because the packet buffer is already ready, even if the content is to be filled in. With this helper, we can already slightly