Re: [PATCH 13/15] hw/riscv/spike.c: simplify create_fdt()

2022-12-26 Thread Daniel Henrique Barboza
On 12/23/22 10:06, Bin Meng wrote: On Thu, Dec 22, 2022 at 2:29 AM Daniel Henrique Barboza wrote: 'mem_size' and 'cmdline' aren't being used and the MachineState pointer is being retrieved via a MACHINE() macro. Remove 'mem_size' and 'cmdline' and add MachineState as a parameter. Why do

Re: [PATCH 13/15] hw/riscv/spike.c: simplify create_fdt()

2022-12-23 Thread Bin Meng
On Thu, Dec 22, 2022 at 2:29 AM Daniel Henrique Barboza wrote: > > 'mem_size' and 'cmdline' aren't being used and the MachineState pointer > is being retrieved via a MACHINE() macro. > > Remove 'mem_size' and 'cmdline' and add MachineState as a parameter. Why do you add MachineState as a

[PATCH 13/15] hw/riscv/spike.c: simplify create_fdt()

2022-12-21 Thread Daniel Henrique Barboza
'mem_size' and 'cmdline' aren't being used and the MachineState pointer is being retrieved via a MACHINE() macro. Remove 'mem_size' and 'cmdline' and add MachineState as a parameter. Signed-off-by: Daniel Henrique Barboza --- hw/riscv/spike.c | 8 +++- 1 file changed, 3 insertions(+), 5