Re: [PATCH 13/18] include/hw/s390x: Add include files for common IPL structs

2024-09-30 Thread Jared Rossi
On 9/30/24 6:42 AM, Thomas Huth wrote: On 27/09/2024 02.51, jro...@linux.ibm.com wrote: ... + +struct IPLBlockPVComp { +    uint64_t tweak_pref; +    uint64_t addr; +    uint64_t size; +}  QEMU_PACKED; Could you please replace the two spaces in front of QEMU_PACKED with just one place? (als

Re: [PATCH 13/18] include/hw/s390x: Add include files for common IPL structs

2024-09-30 Thread Thomas Huth
On 27/09/2024 02.51, jro...@linux.ibm.com wrote: From: Jared Rossi Currently, structures defined in both hw/s390x/ipl.h and pc-bios/s390-ccw/iplb.h must be kept in sync, which is prone to error. Instead, create a new directory at include/hw/s390x/ipl/ to contain the definitions that must be sha

[PATCH 13/18] include/hw/s390x: Add include files for common IPL structs

2024-09-26 Thread jrossi
From: Jared Rossi Currently, structures defined in both hw/s390x/ipl.h and pc-bios/s390-ccw/iplb.h must be kept in sync, which is prone to error. Instead, create a new directory at include/hw/s390x/ipl/ to contain the definitions that must be shared. Signed-off-by: Jared Rossi --- hw/s390x/ip