Re: [PATCH 14/17] crypto/builtin: Split and simplify AES_encrypt_cbc

2020-08-17 Thread Daniel P . Berrangé
On Wed, Aug 12, 2020 at 08:25:34PM -0700, Richard Henderson wrote: > Split into encrypt/decrypt functions, dropping the "enc" argument. > Now that the function is private to this file, we know that "len" > is a multiple of AES_BLOCK_SIZE. So drop the odd block size code. > > Name the functions do

[PATCH 14/17] crypto/builtin: Split and simplify AES_encrypt_cbc

2020-08-12 Thread Richard Henderson
Split into encrypt/decrypt functions, dropping the "enc" argument. Now that the function is private to this file, we know that "len" is a multiple of AES_BLOCK_SIZE. So drop the odd block size code. Name the functions do_aes_*crypt_cbc to match the *_ecb functions. Reorder and re-type the argumen