Re: [PATCH 15/15] hw/i386/pc_piix: Move i440fx' realize near its qdev_new()

Am 13. Juni 2023 09:52:50 UTC schrieb Igor Mammedov : >On Mon, 12 Jun 2023 17:49:10 + >Bernhard Beschow wrote: > >> Am 12. Juni 2023 15:21:19 UTC schrieb Igor Mammedov : >> >On Mon, 12 Jun 2023 16:51:55 +0200 >> >Igor Mammedov wrote: >> > >> >> On Sun, 11 Jun 2023 12:34:12 +0200 >> >> Be

Re: [PATCH 15/15] hw/i386/pc_piix: Move i440fx' realize near its qdev_new()

On Mon, 12 Jun 2023 17:49:10 + Bernhard Beschow wrote: > Am 12. Juni 2023 15:21:19 UTC schrieb Igor Mammedov : > >On Mon, 12 Jun 2023 16:51:55 +0200 > >Igor Mammedov wrote: > > > >> On Sun, 11 Jun 2023 12:34:12 +0200 > >> Bernhard Beschow wrote: > >> > >> > I440FX realization is curren

Re: [PATCH 15/15] hw/i386/pc_piix: Move i440fx' realize near its qdev_new()

Am 12. Juni 2023 15:21:19 UTC schrieb Igor Mammedov : >On Mon, 12 Jun 2023 16:51:55 +0200 >Igor Mammedov wrote: > >> On Sun, 11 Jun 2023 12:34:12 +0200 >> Bernhard Beschow wrote: >> >> > I440FX realization is currently mixed with PIIX3 creation. Furthermore, it >> > is >> > common practice t

Re: [PATCH 15/15] hw/i386/pc_piix: Move i440fx' realize near its qdev_new()

On Mon, 12 Jun 2023 16:51:55 +0200 Igor Mammedov wrote: > On Sun, 11 Jun 2023 12:34:12 +0200 > Bernhard Beschow wrote: > > > I440FX realization is currently mixed with PIIX3 creation. Furthermore, it > > is > > common practice to only set properties between a device's qdev_new() and > > qdev_r

Re: [PATCH 15/15] hw/i386/pc_piix: Move i440fx' realize near its qdev_new()

On Sun, 11 Jun 2023 12:34:12 +0200 Bernhard Beschow wrote: > I440FX realization is currently mixed with PIIX3 creation. Furthermore, it is > common practice to only set properties between a device's qdev_new() and > qdev_realize(). Clean up to resolve both issues. > > Since I440FX spawns a PCI b

Re: [PATCH 15/15] hw/i386/pc_piix: Move i440fx' realize near its qdev_new()

On 11/6/23 12:34, Bernhard Beschow wrote: I440FX realization is currently mixed with PIIX3 creation. Furthermore, it is common practice to only set properties between a device's qdev_new() and qdev_realize(). Clean up to resolve both issues. Since I440FX spawns a PCI bus let's also move the pci_

[PATCH 15/15] hw/i386/pc_piix: Move i440fx' realize near its qdev_new()

I440FX realization is currently mixed with PIIX3 creation. Furthermore, it is common practice to only set properties between a device's qdev_new() and qdev_realize(). Clean up to resolve both issues. Since I440FX spawns a PCI bus let's also move the pci_bus initialization there. Note that when ru